Skip to content

fix: When the discriminator is true, there is no problem with the value#2814

Merged
shaohuzhang1 merged 1 commit intomainfrom
pr@main@fix_condition
Apr 7, 2025
Merged

fix: When the discriminator is true, there is no problem with the value#2814
shaohuzhang1 merged 1 commit intomainfrom
pr@main@fix_condition

Conversation

@shaohuzhang1
Copy link
Copy Markdown
Contributor

fix: When the discriminator is true, there is no problem with the value

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Apr 7, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 2681d02 into main Apr 7, 2025
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_condition branch April 7, 2025 10:56
if (['is_null', 'is_not_null', 'is_true', 'is_not_true'].includes(val)) {
const list = cloneDeep(props.nodeModel.properties.node_data.branch)
list[index]['conditions'][cIndex].value = 1
set(props.nodeModel.properties.node_data, 'branch', list)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code modification seems to be correcting an error in checking condition values. The updated changeCondition function now correctly checks against a list of allowed conditions ('is_null', 'is_not_null', 'is_true', 'is_not_true'). This improvement ensures that only these specific condition types can be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant